chore: Dockerize backend #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmachin
requested review from
mlvieras,
lauta2912,
MBerguer and
chaba11
as code owners
gabrielmachin
force-pushed
the
chore/Dockerize-backend
branch
from
ec01d9d
to
41acb30
Compare
mlvieras
reviewed
Dec 20, 2023
Dockerfile
Outdated
Comment on lines
8
to
9
| RUN npm ci --omit=dev --ignore-scripts | ||
| RUN cp -RL node_modules/ /tmp/node_modules/ |
There was a problem hiding this comment.
Please move this to the second step of the build. Also, on both steps please install NPM version 10.1.0
Dockerfile.dev
Outdated
| # Copy dependency information and install dependencies | ||
| COPY *.json ./ | ||
|
|
||
| RUN npm ci --ignore-scripts |
There was a problem hiding this comment.
Please install NPM 10.1.0 before installing the packages
Dockerfile.dev
Outdated
| RUN npm ci --ignore-scripts | ||
|
|
||
| # Copy source code (and all other relevant files) | ||
| COPY . . |
Dockerfile.dev
Outdated
| COPY . . | ||
|
|
||
| # Generate Prisma Client | ||
| RUN npx prisma generate |
There was a problem hiding this comment.
Move this to docker-dev-cmd
jrg091
reviewed
Dec 21, 2023
gabrielmachin
force-pushed
the
chore/Dockerize-backend
branch
2 times, most recently
from
54b7158
to
122de1a
Compare
mlvieras
approved these changes
Jan 12, 2024
gabrielmachin
force-pushed
the
chore/Dockerize-backend
branch
from
122de1a
to
07cd725
Compare
gabrielmachin
force-pushed
the
chore/Dockerize-backend
branch
from
07cd725
to
7ccca5e
Compare
gabrielmachin
force-pushed
the
chore/Dockerize-backend
branch
from
7ccca5e
to
b961d43
Compare
jrg091
reviewed
Jan 31, 2024
Comment on lines
+9
to
+11
| RUN npm install --ignore-scripts | ||
|
|
||
| CMD [ "npm", "run", "docker-dev-cmd" ] |
There was a problem hiding this comment.
So changing a package means you will need to rebuild the image, right? and manually because docker won't notice that change, is this right?
Something like https://docs.docker.com/compose/file-watch/ would fix this and it may be "needed" (or a volume and check always update the packages), right? Otherwise changing a package will be a "painful" task making hard for someone to adopt this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTION Ticket
Type of change
Description of the change
Modify the
docker-compose.ymlfile to run the backend in a docker container, and also created aDockerfile.devfile to use in the modified docker-compose.Also changed
docker-compose.ymlextension to.yamlsince this is preferred by docker.